Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use modern color function notation #10080

Merged
merged 5 commits into from
Jan 5, 2025
Merged

Use modern color function notation #10080

merged 5 commits into from
Jan 5, 2025
+96 −98

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Dec 19, 2024 •
edited
Loading

Investigating if we can use modern color function notation rather than the legacy. Want to make sure HTMLUnit/ATH is happy with it.

Testing done

  • Tests pass
  • BOM passes

Proposed changelog entries

  • human-readable text

Proposed upgrade guidelines

N/A

Submitter checklist
Preview Give feedback

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist
Preview Give feedback

@timja
Copy link
Member

timja commented Jan 1, 2025

If you want to go ahead with this can you run through a bom build please?

@janfaracik janfaracik mentioned this pull request Jan 3, 2025
Closed
@timja timja added web-ui The PR includes WebUI changes which may need special expertise skip-changelog Should not be shown in the changelog labels Jan 3, 2025
@janfaracik janfaracik marked this pull request as ready for review January 3, 2025 16:50
timja
timja approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timja timja added the pct-successful This PR has successfully passed the full plugin-compatibility-test suite label Jan 3, 2025
@timja timja requested a review from a team January 3, 2025 22:01
@timja
Copy link
Member

timja commented Jan 4, 2025

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jan 4, 2025
A1exKH
A1exKH approved these changes Jan 4, 2025
View reviewed changes
Copy link

@A1exKH A1exKH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janfaracik LGTM.

@krisstern krisstern merged commit 8e68fdd into jenkinsci:master Jan 5, 2025
16 checks passed
@janfaracik janfaracik deleted the use-modern-color-function-notation branch January 5, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krisstern krisstern krisstern approved these changes

@timja timja timja approved these changes

@NotMyFault NotMyFault NotMyFault approved these changes

@A1exKH A1exKH A1exKH approved these changes

Assignees
No one assigned
Labels
pct-successful This PR has successfully passed the full plugin-compatibility-test suite ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@janfaracik @timja @A1exKH @NotMyFault @krisstern